+  RHDN Forum Archive
|-+  Romhacking
| |-+  ROM Hacking Discussion
| | |-+  Final Fantasy VII NES Project
Pages: 1 ... 20 21 [22] 23 24 25
Author Topic: Final Fantasy VII NES Project  (Read 2 times)
Lindblum
Guest
« Reply #315 on: December 03, 2011, 11:07:07 pm »

Quote
I tried the changes for the weapon shop, but I noticed some problems.
You can make an IPS from your modified ROM and send it to me so I can compare it to my own and figure out if either of us made a mistake. 
Lugia2009
Guest
« Reply #316 on: December 04, 2011, 10:33:15 am »

Quote
You can make an IPS from your modified ROM and send it to me so I can compare it to my own and figure out if either of us made a mistake. 

Okay, here's the link.

http://www.mediafire.com/?0sy72fu4ii7suok

I made 2 IPS patches. I found a document in your archive that showed the changes made to the shops, so I made those changes to my ROM, then I made the changes you posted up. When that didn't work, I then took the original Chinese ROM and applied the 99% patch and then made the changes that you posted, but the same thing happened. I included a save-state to test it.

Also, I tried the alterations again and this time, selling the weapons worked fine. I guess I messed up somewhere before, but that part's working now. Buying weapons still doesn't work.
Lindblum
Guest
« Reply #317 on: December 04, 2011, 01:04:40 pm »

I'm not completely sure you applied 4 of the changes.  Just double check these. 
Code:
FunctionCall SubtractInvt, 0x72115, [20][40][E4][EA]
Pointer NewInvtPtrArray, 0x72154, [A0][E3]
Pointer NewInvtPtrArray, 0x7215A, [A0][E3]
FunctionCall InvtLimit, 0x72227, [20][F0][E3][EA][EA][EA][EA][EA]

The part that's definitely my fault is where I typed a byte in Function SubtractInv wrong (0x7646B should be ED, not 13), which caused a branch opcode to jump the wrong direction, and into bad memory.  I'll correct it here and in my other post.
Code:
Function SubtractInv, 0x76450, [AD][CA][6F][C9][04][D0][18][A2][00][BD][74][60][4D][24][6F][29][7F][D0][03][9D]
[74][60][E8][8A][C9][07][90][ED][A9][00][60][B1][02][38][ED][19][6F][60]
« Last Edit: December 04, 2011, 01:14:22 pm by Lindblum »
Lugia2009
Guest
« Reply #318 on: December 04, 2011, 03:29:39 pm »

Quote
I'm not completely sure you applied 4 of the changes.  Just double check these.
Code: [Select]

FunctionCall SubtractInvt, 0x72115, [20][40][E4][EA]
Pointer NewInvtPtrArray, 0x72154, [A0][E3]
Pointer NewInvtPtrArray, 0x7215A, [A0][E3]
FunctionCall InvtLimit, 0x72227, [20][F0][E3][EA][EA][EA][EA][EA]

You're right, I did miss those.

I found out why when I bought something it didn't appear in the inventory, at 0x072282 you put 20 B0 E3 EA EA EA EA EA, when it should be 20 B0 E3 EA EA EA 91 02. I went through each one and reverted them back to the way they were in the 99% patch and when I came to this one, I found it to be the problem.

The shop works perfectly now. Thank you Smiley

December 04, 2011, 09:41:35 pm - (Auto Merged - Double Posts are not allowed before 7 days.)
Floor 70 is done. Here is the before and after:

« Last Edit: December 04, 2011, 09:42:07 pm by Lugia2009 »
Lindblum
Guest
« Reply #319 on: December 05, 2011, 12:44:34 am »

Quote
at 0x072282 you put 20 B0 E3 EA EA EA EA EA, when it should be 20 B0 E3 EA EA EA 91 02
The STA is handled from within my function, so the 91 02 shouldn't have to exist outside of it. 

Great work on the maps and event modifications.  I feel almost sorry about how much work is still ahead of you though. 
Lugia2009
Guest
« Reply #320 on: December 05, 2011, 06:32:40 am »

Quote
Great work on the maps and event modifications.  I feel almost sorry about how much work is still ahead of you though. 

Thanks Smiley. I don't mind doing this, I'm having fun working on this game. I always wanted to do something like this.
vivify93
Guest
« Reply #321 on: December 05, 2011, 09:26:41 am »

Who's the woman behind the pillar? Tifa?
Lindblum
Guest
« Reply #322 on: December 05, 2011, 10:39:50 am »

I think it's Scarlet/Palmer (they're one character in this game).

Even though the original game had a purposeless glowing yellow panel on the floor, it just gives the room an awkward asymmetry here.
« Last Edit: December 05, 2011, 11:19:27 am by Lindblum »
Lugia2009
Guest
« Reply #323 on: December 05, 2011, 11:33:49 am »

Quote
Who's the woman behind the pillar? Tifa?

It is Scarlet/Palmer. In the original game, when Cloud and the others found President Shinra's body, Palmer was hiding behind one of the pillars.

I wonder though, why Sephiroth left his sword behind.

Quote
Even though the original game had a purposeless glowing yellow panel on the floor, it just gives the room an awkward asymmetry here.

Think I should remove it?

December 07, 2011, 05:13:48 pm - (Auto Merged - Double Posts are not allowed before 7 days.)
Shinra HQ Roof is done, here's the before and after:





December 07, 2011, 08:59:24 pm - (Auto Merged - Double Posts are not allowed before 7 days.)
Everything from the beginning of the game up to the world map is done!

Here's the newest patch. It's a patch over the original Chinese version.
http://www.mediafire.com/?atao5ahj37tqfw5

Enjoy  Smiley
« Last Edit: December 09, 2011, 04:34:39 pm by Lugia2009 »
Lindblum
Guest
« Reply #324 on: December 08, 2011, 10:08:38 pm »

I tried the new patch, and the Shinra HQ changes look good, but found new bugs in the weapon store.  Please read the following before applying changes.

In WeaponUserName after the ADC opcode [69] I had typed the wrong number [01] (Which resulted in "Shenzhen Nanjing" being printed near the weapon stats), so I changed it to [49] to point to the characters' abbreviated names in a string array (as my translation had it), but this crashed the game.  I went to 0x3030A to see that instead of the abbreviated names being stored there (After "Equipped" in the string array) there were bytes I didn't expect or understand.  Have the pointer arrays been manipulated?  With that being said, if the abbreviated names can't be restored to the array, you can change my [49] to [02] to use their full names, which will work, but be partially overwritten by weapon stats in the store menus.
Also, all weapons had the wrong prices.  I opened the patched ROM to the NewWeaponPriceArray and saw a completely different array than what was supposed to be stored there ([00][11][22][33][44]...).  I have no explanation for this. 

Code:
Function WeaponUserName, 0x76390, [AD][CA][6F][C9][04][D0][07][AD][2B][6F][18][69][49][60][AD][2B][6F][18][69][09][60]
Array NewWeaponPriceArray, 0x2F480, [0A][14][1E][28][32][3C][46][50][5A][64][6E][78][82][8C][96][A0]
[0A][14][1E][28][32][3C][46][50][5A][64][6E][78][82][8C][96][A0]
[0A][14][1E][28][32][3C][46][50][5A][64][6E][78][82][8C][96][A0]
[0A][14][1E][28][32][3C][46][50][5A][64][6E]
[0A][14][1E][28][32][3C][46][50][5A][64][6E][78][82][8C]
[0A][14][1E][28][32][3C][46][50][5A][64][6E][78][82]
[0A][14][1E][28][32][3C][46][50][5A][64][6E][78][82][8C]
« Last Edit: December 09, 2011, 02:55:58 am by Lindblum »
Lugia2009
Guest
« Reply #325 on: December 09, 2011, 07:40:06 am »

Quote
In WeaponUserName after the ADC opcode [69] I had typed the wrong number [01] (Which resulted in "Shenzhen Nanjing" being printed near the weapon stats), so I changed it to [49] to point to the characters' abbreviated names in a string array (as my translation had it), but this crashed the game.  I went to 0x3030A to see that instead of the abbreviated names being stored there (After "Equipped" in the string array) there were bytes I didn't expect or understand.  Have the pointer arrays been manipulated?  With that being said, if the abbreviated names can't be restored to the array, you can change my [49] to [02] to use their full names, which will work, but be partially overwritten by weapon stats in the store menus.

I didn't mess with the pointer arrays, but I'll see if it can be fixed.

Quote
Also, all weapons had the wrong prices.  I opened the patched ROM to the NewWeaponPriceArray and saw a completely different array than what was supposed to be stored there ([00][11][22][33][44]...).  I have no explanation for this. 

Sorry about that, that was me. I thought earning money to buy the best equipment would make battles more rewarding. I can change it back.


Also, I wanted to change the dialogue in the Kalm inn where Cloud tells his story about him and Sephiroth. Think this sounds alright?

Aeris: Let's head to the Inn.

Barret: So Cloud, let's hear your story....You know, about you and
Sephiroth.

Cloud:....I used to want to be like Sephiroth, so I joined SOLDIER.
After working with Sephiroth on several missions, we became friends.

Barret: You call that a friend?

Cloud: Yeah, well....He's older than me, and he hardly ever talked about
himself.

Cloud: We trusted each other. Until one day....

Cloud: I went with Sephiroth on a mission to Nibelheim to investigate
a malfunctioning reactor. Tifa was our guide to lead us to the reactor.

Cloud: Inside the reactor we discovered creatures created by Shinra. Normal
members of SOLDIER are exposed to mako, but these people were exposed to very
high amounts of Mako. Sephiroth was unlike normal members of SOLDIER....

Cloud: After realizing he may have been created the same way as those monsters,
Sephiroth went into the Shinra mansion and learned about the Cetra,
and The Jenova project. A project to create a human with the powers of the
Cetra by using Jenova's cells. He went mad and set the town on fire, my family,
and friends were killed.

Tifa: My father....

Cloud: Tifa went after him. Inside the reactor I found Tifa injured. I went
after Sephiroth.

Cloud: Sephiroth found his mother, Jenova. He believed she was destined to
rule the world....and that's the end of my story.

Aeris: What happened to Sephiroth?

Cloud: In terms of skill, I couldn't have killed him.

Tifa: Official records state Sephiroth is dead.

Aeris: Shinra, Inc owns the newspaper, so you can't rely on them.

Cloud: I want to know what happened then. I challenged Sephiroth
and lived. Why didn't he kill me?

Aeris: What about Jenova?

Cloud: Shinra shipped it to Midgar.

Aeris: It was missing from the Shinra building.

Tifa: Sephiroth?

Barret: Damn! Don't none of this make sense! I'm going.

Red XIII: ....what a fascinating story.


I looked, and it should all fit.
betakiller
Guest
« Reply #326 on: December 09, 2011, 08:16:23 am »

Quote from: Lugia2009 on December 09, 2011, 07:40:06 am

Also, I wanted to change the dialogue in the Kalm inn where Cloud tells his story about him and Sephiroth.

The new dialogue is cool, but are you going someday create a flashback? And when you'll edit the world map, are you going to add new islands (for example, the one with Wutai).
« Last Edit: December 09, 2011, 10:09:22 am by betakiller »
Nerd42
Guest
« Reply #327 on: December 09, 2011, 12:05:43 pm »

Haven't had a chance to try the new patch yet but please please please for future reference, until you get to what you consider is for sure going to be the final patch which you are not doing any bug fixes for, please please please put the date in the filename of the patch. Otherwise we could end up with an indefinite number of "Latest Patches"
Lugia2009
Guest
« Reply #328 on: December 09, 2011, 12:52:34 pm »

Quote
Haven't had a chance to try the new patch yet but please please please for future reference, until you get to what you consider is for sure going to be the final patch which you are not doing any bug fixes for, please please please put the date in the filename of the patch. Otherwise we could end up with an indefinite number of "Latest Patches"

Good idea, I'll do that.

Quote
The new dialogue is cool, but are you going someday create a flashback? And when you'll edit the world map, are you going to add new islands (for example, the one with Wutai).

I'm not sure if I can, I would need more space in the event banks. I have leftover bytes from other events, hopefully I'll be able to figure out how to change the pointers for them so I can use the leftovers.
As for the map, I'm going to try and make it match the psx version as best as I can.

December 09, 2011, 04:27:55 pm - (Auto Merged - Double Posts are not allowed before 7 days.)
Quote
In WeaponUserName after the ADC opcode [69] I had typed the wrong number [01] (Which resulted in "Shenzhen Nanjing" being printed near the weapon stats), so I changed it to [49] to point to the characters' abbreviated names in a string array (as my translation had it), but this crashed the game.  I went to 0x3030A to see that instead of the abbreviated names being stored there (After "Equipped" in the string array) there were bytes I didn't expect or understand.  Have the pointer arrays been manipulated? 

I realized why it did this, when I first started working on the game I tried using the 99% patch, but the game kept freezing when I arrived at Tifa's bar. So I ended up not using the patch. But that was probably my fault. When I started working on the game I didn't really know what I was doing, I may have applied a few patches which caused the game to crash.

I copied and pasted that segment over on the new version and it's fixed now.
I changed the download link to the fixed version, sorry about that.
« Last Edit: December 10, 2011, 07:19:48 am by Lugia2009 »
betakiller
Guest
« Reply #329 on: December 10, 2011, 11:01:36 am »

I found some little bugs, but I'll report about them a bit later. Also, could you make cursor for choises in dialogues more visible? Make it red, because pink is very hard to see on white background.
« Last Edit: December 10, 2011, 11:32:53 am by betakiller »
Pages: 1 ... 20 21 [22] 23 24 25  


Powered by SMF 1.1.4 | SMF © 2006-2007, Simple Machines LLC