Right -- tile FF is sprite 0.  If you blank it, sprite 0 is blank, so it can never hit.

As I was hacking around last night, I discovered the same thing. My current thinking on the matter is to alter the enemy sprite handling routines to use a second table if the enemy ID is above a given number. As the new enemies are all likely to have IDs higher than the existing ones, it should work nicely.

I know why the Gooba sprite tile that's simply a mirror image was done that way, rather than by reusing the other tile. The game has a horizontal flip routine that doesn't play nice with mirrored tiles. Mostly it's used for enemies (and Mario) when they are moving or facing to the right. However, it's also used by the special cased Goomba animation routine, even though the Goomba keeps moving left.

The horizontal flip routine works by swapping the left and right tiles and then enabling the horizontal flip attribute on them. This means that if you've set the horizontal flip attribute of an individual tile, if the sprite is modified by the routine, the results do not turn out correctly.

The only enemy in the game that has mirrored tiles and faces both directions is Lakitu and they avoided the issue in his case by not using the horizontal flip routine, but instead by handling it with a special case in the general enemy mirroring code.

It'd be tempting to just restore the Goomba tile and find another one to use, but it's not the best solution. For starters, the barrel is going to need to be treated similarly due to it's mirrored tile. Plus, the Fighter Fly, with one animation frame mirrored and the other not, is going to need to be handled.

The solution I'm pursing is to turn the Goomba from a single frame into two frames and handle the mirroring in a special case like they did with Lakitu. However, I've yet to figure out how to determin which frame the enemy is on when the mirroring routine is called. The Lakitu code isn't any help here as it does it's frame and direction determination based on stuff that has to do with enemy frenzy and the Spiny throwing.

I'm confident that it can be done, but I've yet to figure out exactly how yet. Until I do, I can't really fully impliment the graphics additions. However, it's nice to see that you've got the levels edited and ready for when I get the power-up graphics inserted.

Do you think I should release an expanded ROM with the placeholder graphics like I did with the 1-4 patch? Or should I wait until the power-ups have graphics of thier own?

All righty then, I should have the latest patch released within the hour.

Edit 1: Hey frantik, your first link is broken. I managed to figure it out (you forgot the dot), but I thought I'd let you know.

Edit 2: You can get the latest and greatest expanded ROM patch here.

There are some flaws I've discovered in the latest IPS patches of this hack. Among them:
1. Some of the ? blocks are replaced by L-pipes (remember when some of the accessible pipes were replaced by ? blocks before in earlier versions of this hack?).
2. Lakitu's palette is now color keyed by area type.
3. Some ? blocks are also replaced by flagpoles (I discovered one in the first castle level, and in World 8-3).

Also, some other things you still didn't fix:
*Still no points for shooting Piranha Plants with fireballs (as Fiery Mario). In the original SMB1, Piranhas were 200 points.

Have you got anymore ways to work around these problems?

Thank you,



Ben

Currently the demo data is being extracted from whatever world 4 patch is being used to build the release. If your current patches have a proper demo, it should work, but if it doesn't I may have done something wrong in the extraction (proably a typo of some sort.) I'll look into it.

In regards the points for killing Piranha Plants, I don't think this has been mentioned before. I'm not aware of any changes I made to that sort of thing, but there are still a small number of changes that where copied wholesale from the patch frantik originally used to add the Red Piranha Plants. (Although, not very many any more.) It may be related to one of those or an unintertional (and unbeknownst to me) side effect of some other change. Does this affect all Piranha Plants, or just the Red ones?

No, the Blooper swim height change hasn't been added. I've yet to get around to it. BTW, I don't recall making any changes related to water height (although I may have forgotten). Besides the Blooper one, have you made any that aren't in the expanded ROM? Also, are there any that still need to be made? (I seem to recall Mario being able to swim right out of the water in some testing I did a while back.)

You can get the latest expanded SMBS patch here. Changes in this patch are mostly bug fixes.

I've implimented the proper swim height checks for Mario and the Bloobers, so that they can no longer swim above the water line. These changes where in the unexpanded ROM, but hadn't been incorporated into the expanded codebase until now.

Piranha plants give points when killed like they're supposed to. This includes both Red and Green varieties. This bug was inherited from the Japanese inverted pipe patch Frantik originally used or my incoporation of it's changes into the code. (I'm not sure which.)

The demo importation code has been fixed so that the demo now does what it's supposed to do. This was the result of an off-by-one addressing error that caused the timing data to include the last byte of the action data as it's first value.

Finally, there has been a change to the special power ups. For the time being, they've been replaced with flags that give a 1 Up. This is to make them actually useful and look decent until such time as they can be implimented completely.

Hack and Enjoy.

There's another one left unchanged in the second part of World 3-2, in which the ? Block is supposed to be the accessible pipe which brings you to the second part of the first map screen of the level.

~Ben